The Standard

Summary

For Swapping tokens swapFee should be considered for calculating minimumAmountOut.

Vulnerability Details

uint256 minimumAmountOut = calculateMinimumAmountOut(_inToken, _outToken, _amount);

In SmartVaultV3 contract inside function swap() while calculating minimumAmountOut, swapFee is not subtracted from _amount
which result in bigger calculated minimumAmountOut then it should be as amountIn provided in params is amountIn: _amount - swapFee.

Impact

Incorrect calculation of minimumAmountOut results in wrong calculation in the amount of _outToken while swapping.

Tools Used

Manual

Recommendations

Subtract swapFee from _amount in the calculation.

uint256 minimumAmountOut = calculateMinimumAmountOut(_inToken, _outToken, _amount - swapFee);