The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

`SmartVaultV3` Use shift Right/Left instead of division/multiplication if possible

Summary

The use of shift Right/Left instead

Vulnerability Details

use more gas

Impact

use more gas

Tools Used

foundry
manual

Recommendations

use of shift Right/Left instead to divide and multiply

+ uint256 fee = ( _amount <<ISmartVaultManagerV3(manager).mintFeeRate() )>> ISmartVaultManagerV3(manager).HUNDRED_PC();
- uint256 fee = _amount * ISmartVaultManagerV3(manager).mintFeeRate() / ISmartVaultManagerV3(manager).HUNDRED_PC();
+ uint256 requiredCollateralValue = (minted << _manager.collateralRate() )>> _manager.HUNDRED_PC();
- uint256 requiredCollateralValue = minted * _manager.collateralRate() / _manager.HUNDRED_PC();
Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.