Submission Details
Severity:
The `amountOutMinimum` calculated in `swap` may not be the one user is willing to trade for.
Vulnerability Details
It is always better if the amountOutMinimum is provided by user and not calculated by protocol. Often times the calculated amount is not the one which user might always wish to go for. The protocol can calculate if user is unwilling to submit his own output amount, but generally user must have complete control over accepting the swap result.
Impact
User swaps for the ratio he is not willing to pay for.
Tools Used
Manual
Recommendations
Let user pass the amountOutMinimum in the function params.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Lack of quality
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.