The Standard
The Standard
DeFiHardhat
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

QA

0xhacksmithh

[Low-1] While setting fees there is no upperbound

function setMintFeeRate(uint256 _rate) external onlyOwner {
mintFeeRate = _rate;
}
​
function setBurnFeeRate(uint256 _rate) external onlyOwner {
burnFeeRate = _rate;
}
​
function setSwapFeeRate(uint256 _rate) external onlyOwner {
swapFeeRate = _rate;
}

While setting those fees there should be a upper bound(upper limit) above which value can't be changed

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/SmartVaultManagerV5.sol#L103-L113

[L-2] Fee implementation should be used via Timelock contract

function setMintFeeRate(uint256 _rate) external onlyOwner {
mintFeeRate = _rate;
}
​
function setBurnFeeRate(uint256 _rate) external onlyOwner {
burnFeeRate = _rate;
}
​
function setSwapFeeRate(uint256 _rate) external onlyOwner {
swapFeeRate = _rate;
}

There should be a time period given to User to decide whether they are agree with new fee structure. If not then they will leave project.

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/SmartVaultManagerV5.sol#L103-L113
Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

0xhacksmithh Submitter
over 1 year ago
hrishibhat Lead Judge
over 1 year ago
hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.