Submission Details
Severity:
maxMintable() is calculated incorrectly
Summary
maxMintable() is supposed to be a rate percentage of the total collateral deposited(which should be totalCollateral * rate / 10000), However it was implemented with
euroCollateral() * ISmartVaultManagerV3(manager).HUNDRED_PC() / ISmartVaultManagerV3(manager).collateralRate();
Vulnerability Details
This vulnerabiltiy is due to the calculation of the maxMintable() which is a crucial function for the protocol and represents a precentage rate of the totalColleteral deposited, However, was done in the reverse as shown above.
Impact
This affect the overall accounting of the vault contract for every user.
Tools Used
Visual Studio Code
Recommendations
Modify to this:
euroCollateral() * ISmartVaultManagerV3(manager).collateralRate() / ISmartVaultManagerV3(manager).HUNDRED_PC();
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.