The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Valid

SmartVaultV3 Swap Fee Discrepancy

Vulnerability Details

The function calculates the swap fee based on the ISmartVaultManagerV3 contract's swapFeeRate() and HUNDRED_PC() values.
However, the calculated fee isn't utilized in the params struct, where a hardcoded value of 3000 is used for the fee field.

Impact

This mismatch results in inconsistent and potentially inaccurate swap fees

Tools Used

Manual Review

Recommendations

Replace the hardcoded fee: 3000 in the params struct with fee: swapFee.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

fixed-uni-fee

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

hardcoded-fee

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.