Submission Details
Severity:
Add a check before transferring token for amount>0
Summary
In LiquidationPoolManager.distributeFees() transfer euros to protocol without checking the amount>0
Vulnerability Details
function distributeFees() public {
IERC20 eurosToken = IERC20(EUROs);
uint256 _feesForPool = eurosToken.balanceOf(address(this)) * poolFeePercentage / HUNDRED_PC;
if (_feesForPool > 0) {
eurosToken.approve(pool, _feesForPool);
LiquidationPool(pool).distributeFees(_feesForPool);//@audit due to precision loss complete fee isn't distributed
}
//@audit no check for transferring zero tokens
eurosToken.transfer(protocol, eurosToken.balanceOf(address(this)));
}
https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPoolManager.sol#L40
it transfer tokens without checking the amount is greater than zero
Add a check that if(eurosToken.balanceOf(address(this))>0) then transfer the tokens
Tools Used
Manual
Recommendations
See Vulnerability Details
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Lack of quality
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.