The Standard

Summary

Use of block.timestamp for deadline of a swap can lead to loss for a user.

Vulnerability Details

The deadline of a swap is set to block.timestamp in the swap function. What this means is that a validator can hold the swap transaction and the block the transaction is eventually put into will be the block.timestamp.

By this, validators determine the timeframe within which a swap should be included in a blockchain and not the user.

Impact

Swap may not be immediate and this can result to loss for a user since crypto is volatile.

Tools Used

Manual review

Recommendations

I suggest use of a deadline parameter where users can input deadline they want.