Submission Details
Severity:
distributeAssets could lead to DOSed liquidation due to growing holders
Summary
Distribution of Assets could DoS due to growing arrays of holders/stakers.
Vulnerability Details
distributeAssets() loops through all the available users in other to record their portion for rewards during liquidation, the issue is that size of holders is dynamic and used through a nested for loop, this could hit the block size limit or OOG exception.
Impact
Liquidation could be DoSed and vaults would not be liquidated.
Tools Used
Manual Review
Recommendations
consider distributing assets in batches or change the implementation to checkpoint user rewards
Updates
Lead Judging Commences
hrishibhat almost 2 years ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.