The Standard

Summary

There are no events for critical operations in the Liquidation.sol contract.

Vulnerability Details

Several critical operations in the Liquidation.sol contract do not trigger events. As a result, it will be difficult to review the correct behavior of the contracts once they have been deployed. Without events, users and blockchain-monitoring systems will fail to detect suspicious behavior or activity.

There are many instances of functions not emitting an event:

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L134

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L149

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L164

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L182

https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L205

Tools Used

Manual Review

Recommendations

Short-term: Add events for all critical operations. Events aid in contract monitoring and the detection of suspicious behavior or activity.

Long-term: Consider using a blockchain-monitoring system to track any suspicious behavior in the contracts. The system relies on several contracts to behave as expected.
components.