The Standard

Summary

SmartVaultManagerV5::vaults function is returning SmartVaultData() for each of the vaults owned by the caller. But, in reality, the values being return are state level variables of SmartVaultManagerV5.

example: All the three variable returned as part of SmartVaultData is not specific to the vault, but instead are values configured in SmartVaultManager.

1. collateralRate

2. mintFeeRate

3. burnFeeRate

Vulnerability Details

The read looks like specific variables for each vault, but instead they are same across all vaults. So, it is better to render and return as common variables
instead of values specific to each vault.

Impact

None

Tools Used

Manual Review

Recommendations

Render them as config variables that are shared across all vaults instead of illustrating as vault specific values.