The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Valid

Uniswap fee hardcoded will not be favorable for all pools #ETH/EURt ARB/EURC

Summary

It appears that in the exactInputSingleParams function, the fee for https://github.com/Cyfrin/2023-12-the-standard/blob/91132936cb09ef9bf82f38ab1106346e2ad60f91/contracts/SmartVaultV3.sol#L221 is hard coded, which can limit the available options and may result in suboptimal routes being selected. Specifically, any swaps involving the ETH path will utilize the incorrect pool and will utilize the ETH/USDC 30% option instead.

Vulnerability Details

Impact

Tools Used

Recommendations

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

fixed-uni-fee

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

hardcoded-fee

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.