The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Valid

SmartVaultV3.swap() swap with deadline: block.timestamp offers no protection

Summary

SmartVaultV3.swap() swap with deadline: block.timestamp offers no protection

Vulnerability Details

Whichever block the txn will be included in will be block.timestamp, so setting the deadline to block.timestamp offers no protection as validators can hold the transaction indefinitely.

Impact

The transaction can be held indefinitely for MEV until it results in maximum slippage.

Tools Used

Manual

Recommendations

Allow function caller (owner of the smart vault) to specify deadline parameter.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

deadline-check-low

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

deadline-check

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.