Submission Details
Severity:
Calculating ```costInEuros``` is susceptible to precision loss due to division before multiplication
Summary
Division before multipliction can result in rounding down errors, hence to minimize any rounding errors we should to perform multiplication before division
Vulnerability Details
In function distributeAssets() when calculating costEuros division is performed before multiplication
uint256 costInEuros = _portion * 10 ** (18 - asset.token.dec) * uint256(assetPriceUsd) / uint256(priceEurUsd) * _hundredPC / _collateralRate;
Impact
Precision loss may result in a lost of funds for the protocol/user
Tools Used
Manual
Recommendations
The multiplication should occur before division
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.