Submission Details
Severity:
Using block.timestamp for deadline could result in loss of funds for the user
Summary
This vulnerability stems from the fact that using block.timestamp for deadline could result in loss of funds for the user
Vulnerability Details
https://github.com/Cyfrin/2023-12-the-standard/blob/91132936cb09ef9bf82f38ab1106346e2ad60f91/contracts/SmartVaultV3.sol#L223
Impact
protocols should let users who interact with Swaps set expiration deadlines. Without this, there's a risk of a serious loss of funds for anyone starting a swap, cause it can be manipulated
Tools Used
Manual Review
Recommendations
Add deadline params for users to decide the expiration deadlines
deadline: deadline
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
deadline-check-low
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.