The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Invalid

Fees collected from swaps are not distributed to stakers

Vulnerability Details

SmartVaultV3#swap sends swapFee to the protocol, which, according to README, is LiquidationPoolManager. However, unlike the fees from EUROs mints/burns which are distributed via distributeFees, there's no such function in LPM to distribute fees collected from swaps, so they will stay in LPM.

Impact

Users and protocol treasury do not receive fees from swaps.

Recommendations

Implement a separate function similar to distributeFees that would distribute fees from swaps, or include the logic directly into distributeFees.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

informational/invalid

aslanbek Submitter
over 1 year ago
hrishibhat Lead Judge
over 1 year ago
aslanbek Submitter
over 1 year ago
hrishibhat Lead Judge
over 1 year ago
hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.