The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Invalid

Owner is not initialized

Summary

The contract SmartVaultManagerV5 inherits the OwnableUpgradeable contract and uses the onlyOwner modifier, but the OwnableUpgradeable contract is not initialized, so the owner is always address(0) address

Vulnerability Details

For using OwnableUpgradeable contact, main contract should call __Ownable_init() function, which transfer ownership to msg.sender, but this is not done in the SmartVaultManagerV5 contract and there is not even an initialize function, so the owner address is zero.

Impact

Owner could not call any function with modifier onlyOwner

Tools Used

Manual review

Recommendations

Add function initialize() and call __Ownable_init() inside of it.

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

uninitialized-variables

informational/invalid

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

uninitialized-variables

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.