Submission Details
Severity:
Precision Loss in distributeAssets() function
Summary
The contract has precision loss issue in the distributeAssets() function. The contract performs division before multiplication(Decimal Normalization).
Vulnerability Details
uint256 costInEuros = _portion * 10 ** (18 - asset.token.dec) * uint256(assetPriceUsd) / uint256(priceEurUsd) * _hundredPC / _collateralRate;
Impact
This results in a loss in precision. Specifically, the costInEuros wont be as accurate
Tools Used
Manual review
Recommendations
Rearrange the operation to perform multiplication before division. This can help prevent the loss of precision.
The correct line should therefore be:
uint256 costInEuros = ((_portion * 10 ** (18 - asset.token.dec)) * uint256(assetPriceUsd) / uint256(priceEurUsd)) * _hundredPC / _collateralRate;
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.