The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Valid

Precision loss due to division before multiplication

Summary

Solidity's integer division truncates. Thus, performing division before multiplication can lead to precision loss.

Vulnerability Details

https://github.com/crytic/slither/wiki/Detector-Documentation#divide-before-multiply

Recommendations

Consider ordering multiplication before division:

uint256 costInEuros = _portion * 10 ** (18 - asset.token.dec) * uint256(assetPriceUsd) * _hundredPC / uint256(priceEurUsd) / _collateralRate;
Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

precision

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.