Submission Details
Severity:
LiquidationPoolManager.setPoolFeePercentage should distribute fees
Summary
LiquidationPoolManager.setPoolFeePercentage should distribute fees before changing fee rate.
Vulnerability Details
LiquidationPoolManager.setPoolFeePercentage function allows to change fee percentage that goes to the pool. Once it's done, then current accrued fees will be distributed in wrong ratio, when next distributeFees call will be done. Thus, users will get wrong percentage of fees.
Impact
Pool will get incorrect fees percentage for previous period.
Tools Used
VsCode
Recommendations
When you change fee rate, then call distributeFees before.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.