The Standard

Summary

Contract owner not set in the constructor

Vulnerability Details

In the previous version of Openzeppelin's Ownable.sol, the deployer is automatically made the owner of the contract. However, in the newest version of Ownable.sol (version 5), this is no longer the case.

See: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/access/Ownable.sol

A contract using Ownable.sol must set the owner of the contract to effectively use the "onlyOwner" modifier.

Impact

setPoolFeePercentage function marked by the "onlyOwner" modifier will revert because owner of the contract is not set.

Tools Used

Manual review

Recommendations

Set the owner in the constructor.