The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Valid

Uniswap Fee is hardcoded in SmartVaultV3.sol

Summary

In SmartVaultV3.sol the Uniswap Fee is hardcoded to 3000, which will lead to non optimal routes. This will lead to losses compared to optimal routing

Vulnerability Details

This hardcoded value will lead to using pools with higher fees. As stated in the Uniswap Docs:
" fee The fee tier of the pool, used to determine the correct pool contract in which to execute the swap"

Impact

For example the there is aLINK/USDC pool for 0.05% fee, as well as ARB / USDC for 0.05%` fee and so on.
So the optimal route is different than 0.3% as hardcoded.
Therefore using the current implementation would create a significant loss of revenue.

Tools Used

Manual review

Recommendations

Updates

Lead Judging Commences

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

fixed-uni-fee

hrishibhat Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

hardcoded-fee

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.