The Standard

Summary

SmartVaultV3::mint function does not protect against precision loss in the fee calculation

Vulnerability Details

SmartVaultV3::mint function does not protect against precision loss in the fee calculation. The same precision error found in the burn function.

Impact

Multiple transactions over a period of time adds up and leads to losses for the system.

Tools Used

Manual Review

Recommendations

diff
- uint256 fee = _amount * ISmartVaultManagerV3(manager).mintFeeRate() / ISmartVaultManagerV3(manager).HUNDRED_PC();

diff
+ uint256 fee = (_amount * ISmartVaultManagerV3(manager).mintFeeRate()) / ISmartVaultManagerV3(manager).HUNDRED_PC();