Lack of price feeds support for protocol's collateral tokens
Summary
WBTC, ARB, LINK, PAXG tokens are basic collateral tokens of The Standard protocol, and in the future more ERC20 tokens are to be supported.
In the protocol, it always assume that TOK/USD price feeds exist in Chainlink service, however on Mainnet, PAXG/USD doesn't exist but PAXG/ETH exists.
Vulnerability Details
From the protocol documentation, it says that 4 collateral tokens above should be compatible through out any EVM chains with Chainlink and Uniswap supported.
Also in PriceCalculator contract, it only supports price feeds against USD price.
However, specifically on Mainnet, there is no feed for PAXG/USD but PAXG/ETH is supported.
This means that PAXG can't be used as collateral on Mainnet blocking protocol feature.
Impact
Limited price feeds support block features of the protocol because of incompatibility.
Also, for most of ERC20 tokens won't have price feeds against USD but they will have price feeds against ETH.
Tools Used
Manual Review
Recommendations
Rather than expecting TOK/USD price feeds on Chainlink services, the protocol should support price calculation using combined price feeds like TOK/ETH * ETH/USD, which will exist all the time.
Lead Judging Commences
informational/invalid
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.