Submission Details
Severity:
LiquidationPool : Position Struct holder Variable is not Need
Summary
Issue was waste if gas when you create Mappaing where you map the Position inside it with holder:address then I think it not need to create separate variable for it.
Vulnerability Details
waste of gas, in below piece of code you can clearly see holder and mapping address is some so better is used one and not waste gas. on it
function consolidatePendingStakes() private {
uint256 deadline = block.timestamp - 1 days;
for (int256 i = 0; uint256(i) < pendingStakes.length; i++) {
PendingStake memory _stake = pendingStakes[uint256(i)];
if (_stake.createdAt < deadline) {
positions[_stake.holder].holder = _stake.holder; // A: waste of gase explaine inside th structure
positions[_stake.holder].TST += _stake.TST;
positions[_stake.holder].EUROs += _stake.EUROs;
deletePendingStake(uint256(i));
// pause iterating on loop because there has been a deletion. "next" item has same index
i--;
}
}
}
Impact
waste gas
Tools Used
Manual
Recommendations
remove from struct and used only mapping.
Updates
Lead Judging Commences
hrishibhat almost 2 years ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.