Submission Details
Severity:
SmartVaultV3: swap fee is fixed amount
Summary
when you look at swap function you will see on the first link of function you are calculation swapFee but in you go down where you create params for external functions call you will found that you did used the swapFee which we calculation earlier.
Vulnerability Details
Wrong fee or fixed value on fee ,this fee either be equal to swapFee or it will be fixed like 3000 or maybe need setFee functions
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter.ExactInputSingleParams({
tokenIn: inToken,
tokenOut: getSwapAddressFor(_outToken),
// because this contract is no upgradabel it will be more difficult to change fee in future
fee: 3000, // @audit-info this fee not be equal to swapFee or it will be fixed like 3000 or maybe need set fee functions
recipient: address(this),
deadline: block.timestamp,
amountIn: _amount - swapFee,
amountOutMinimum: minimumAmountOut,
sqrtPriceLimitX96: 0
});
Impact
charge wrong fee.
Tools Used
Manual review.
Recommendations
Used swapFee with you calculate earliar or if it like cont value then create proper setter and getter
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.