The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Declare Errors for your require statements

Summary

in your functions that need a require statement you are using strings as your errors

modifier onlyLiquidator {
require(msg.sender == liquidator, "err-invalid-liquidator");
_;
}
modifier ifMinted(uint256 _amount) {
require(minted >= _amount, "err-insuff-minted");
_;
}
modifier ifNotLiquidated {
require(!liquidated, "err-liquidated");
_;
}

Tools Used

manual review

Recommendations

declare Errors and your them in your require statements

error InsufficientMinted();
error AlreadyLiquidated();
// ... rest of your contract code ...
modifier ifMinted(uint256 _amount) {
require(minted >= _amount, InsufficientMinted());
_;
}
modifier ifNotLiquidated {
require(!liquidated, AlreadyLiquidated());
_;
}
Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!