The Standard

Summary

In the SmartVaultManagerV5 contract, it is missing a mutator method for tokenManager. There is only getter/accessor methor to view tokenManager address. Furthermore in SmartVaultv3, it uses the old tokenManager address. I understand that the tokenManager has been set in previous version, and the SmartVaultManagerV5 will be the logic/implementation contract for the proxy. Iknow that tokenManager is a trusted entity, but, it will be wise to have a mutator method to set a new tokenManager.

Let say that the protocol team wants to change the tokenManager address for whatever reason, they can't do it unless they create and deploy a whole new contract let's say SmartVaultManagerV6. You have to shift the native ether and tokens again for this to happen which clearly is troublesome and may need a new audit again for implementing new logic. If you can fix it at a low cost, why not?

Impact

Missing mutator/settor method for setting tokenManager.

Tools Used

Manual Review

Recommendations

Add a mutator/settor method for tokenManager address.