The Standard

Summary

In SmartVaultV3.sol, swap() does not set an expiration deadline, resulting in loss of funds when swapping tokens.

Vulnerability Details

The deadline parameter in the swap() is set to block.timestamp. That means the function will accept a token swap at any block.timestamp which means there is no expiry deadline.

swap() does not allow the function caller to submit a deadline for their actions which execute swaps on Uniswap V3. This missing feature enables pending transactions to be maliciously executed at a later point.

Impact

Without an expiration deadline, a malicious miner/validator can hold a transaction until they favor it or they can make a profit.

Tools Used

Manual review

Recommendations

Set the deadline parameter with desired timestamp. This user defind timestamp will ensure, once deadline is passed the transaction will expire.