The Standard

Summary

SmartVaultManagerV5 inherits both ERC721Upgradeable and OwnableUpgradeable. However, the SmartVaultManagerV5 does not initialize either of these parent contracts. This can lead to broken functionality in the SmartVaultManagerV5 when it comes to determining ownership and details about the ERC721 token.

Vulnerability Details

SmartVaultManagerV5 does not have an initializer function nor calls __ERC721_init or __Ownable_init .

Impact

Ownership and ERC721 token details are broken due to initialization never being called.

Tools Used

Manual Review

Recommendations

Add an initializer function that calls both __Ownable_init and __ERC721_init inside an initialize function. The protocol will have to be sure to call initialize within the same transaction that the contract is deployed.

Sources:

ERC721 token initializer

Ownable token initializer