Submission Details
Severity:
Failure to return failed message in case of error
Summary
lack of an error message can make debugging more challenging and reduce the clarity of the contract's behavior for other developers or auditors.
(bool _sent,) = payable(msg.sender).call{value: _rewardAmount}("");
require(_sent); //@udit-info return some message
https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPool.sol#L199
https://github.com/Cyfrin/2023-12-the-standard/blob/main/contracts/LiquidationPoolManager.sol#L50
Tools Used
manual review
Recommendations
you should add an error message to the require statement. This message will be returned when the condition inside require fails, providing more context about the failure.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.