No validation that poolFeePercentage is less or equal to 100%
Summary & Vulnerability Details
Pool fee percentage determines the percentage of the fees gathered by the protocol that will go to the LiquidationPool to be distributed to the stakers. poolFeePercentage is defined in LiquidationPoolManager by the constructor and in a setter. In either case it is never checked if the value is bigger than 100000, 10e5.
Impact
If the value of poolFeePercentage is ever set to a value bigger than 100% the distribution of fees will revert, also not allowing the following functions, liquidations (LiquidationPoolManager.runLiquidation) and increase and decrease stake on the liquidity pool.
Recommendations
Check that the value of poolFeePercentage on LiquidationPoolManager constructor and setter is <= 10e5
Lead Judging Commences
informational/invalid
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.