Submission Details
Severity:
Absence of a 'require' keyword
Summary
Missing a 'require' keyword in the function
Vulnerability Details
It would be a better solution if a 'require' keyword is added just before the 'for' loop in the 'holderPendingStakes' function. Otherwise, it could lead to entering an infinite loop and could be an attack vulnerability.
Tools Used
Manual review
Recommendations
Delete the 'if (_pendingStake.holder == _holder)' statement inside the 'for' loop and replace it just before the loop with 'require(_pendingStake.holder == _holder, "err-invalid-holder");'
The new function should look like this:
function holderPendingStakes(address _holder) private view returns (uint256 _pendingTST, uint256 _pendingEUROs) {
require(_pendingStake.holder == _holder, "err-invalid-holder");
for (uint256 i = 0; i < pendingStakes.length; i++) {
PendingStake memory _pendingStake = pendingStakes[i];
_pendingTST += _pendingStake.TST;
_pendingEUROs += _pendingStake.EUROs;
}
}
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.