The Standard

Summary

The LiquidationPoolManger and SmartVaultV3 will be compiled with different versions because of inconsistent use of solidity pragma.

Vulnerability Details

SmartVaultV3 and smartVaultManagerv5 are using solidity version 0.8.17 but on the other side, the LiquidationPoolManager and LiquidationPool are using the floating pragma of ^0.8.17, this will compile the contract with the newest version of solidity 0.8.23.

It is always recommended to deploy the contract will the same bug-free soldiity version rather than using floating pragma.

read more

Impact

With a floating pragma, contracts may accidentally be deployed using an outdated or problematic compiler version which can cause bugs, putting your smart contract's security in jeopardy. In addition to this if the contract is deployed with version ≥ 0.8.20 then PUSH0 opcode is not supported by L2s like arbitrum.

Tools Used

Manual review

Recommendations

Use consistent solidity version across all contracts.