The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: medium
Invalid

UniswapV3 Router swaps do not support Fee-On-Transfer tokens whilst `PAXG` is supported by the system

Vulnerability Details

As per official documentation by Uniswap (https://docs.uniswap.org/concepts/protocol/integration-issues)

Fee-on-transfer and rebasing tokens will not function correctly on v3.

Fee-on-transfer tokens will not function with our router contracts. As a workaround, the token creators may create a token wrapper or a customized router. We will not be making a router that supports fee-on-transfer tokens in the future.

The protocol supports PAXG as a swappable token in SmartVaultV3.sol#swap() but has no custom logic to accommodate for a fee-on-transfer token so any swaps with PAXG as tokenIn will fail.

Impact

PAXG is supported but cannot be swapped when it's supposed to be able to be.

Tools Used

Manual Review

Recommendations

Follow UniswapV3 Recommendations in documentation page I provided.

Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

fee-on-transfer

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Out of scope
Assigned finding tags:

fee-on-transfer

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!