Submission Details
Severity:
consolidatePendingStakes will skip stakes which were made at the time of the deadline
Summary
There is an off-by-one issue in the if statement.
Vulnerability Details
In the consolidatePendingStakes function, there is an off-by one issue when the if statement is executed.
function consolidatePendingStakes() private {
uint256 deadline = block.timestamp - 1 days;
for (int256 i = 0; uint256(i) < pendingStakes.length; i++) {
PendingStake memory _stake = pendingStakes[uint256(i)];
if (_stake.createdAt < deadline) {
positions[_stake.holder].holder = _stake.holder;
positions[_stake.holder].TST += _stake.TST;
positions[_stake.holder].EUROs += _stake.EUROs;
deletePendingStake(uint256(i));
// pause iterating on loop because there has been a deletion. "next" item has same index
i--;
}
}
}
As you can see, the check will execute only if the stake was created before the deadline, but the deadline should be inclusive as they should not be accepted after the deadline.
Impact
This can leave behind some stakes, which will result in loss of funds
Tools Used
Manual Review
Recommendations
Change the if statement as follows:
if (_stake.createdAt <= deadline)
Updates
Lead Judging Commences
hrishibhat almost 2 years ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.