The Standard

The Standard
DeFiHardhat
20,000 USDC
View results
Submission Details
Severity: low
Invalid

There is no mechanism in vault to allow owner to withdraw unaccepted tokens

Summary

There is no mechanism in vault to allow owner to withdraw unaccepted tokens

Vulnerability Details

Smart vault deposits are done through standard transfer to the smart vault address for both native and non native tokens.
However after sending a token to the smart vault address, it must be accepted as collateral by the token manager in order to be counted as collateral.
This leave a door for unaccepted tokens to be stuck inside the smart vault forever.
Consider this scenario

  • Alice own a smart vault ande she wants to use a token of her choice as collateral to borrow against

  • Alice sends her tokens to the vault, for the sake of this example let says she sends 1000 LINK to the vault

  • Next LINK does not get accepted by the token manager

  • So it does not get used as collateral and gets stucked inside the smart vault contract

  • After Alice default and gets liquidated, and even without beng liquidated , alice can't withdraw her tokens from the vault

Impact

User funds will gets stucks inside smart vault forever

Tools Used

Manual review, VsCode

Recommendations

I am thinking of a function to allow vault owner to withdraw unaccepted tokens that are sent to smart contract

Updates

Lead Judging Commences

hrishibhat Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

informational/invalid

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!