Submission Details
Severity:
liquidation bug, SmartVault3.sol
Summary
liquidation can be bypassed if protocol address is faulty
Vulnerability Details
function liquidateNative() private {
if (address(this).balance != 0) {
(bool sent,) = payable(ISmartVaultManagerV3(manager).protocol()).call{value: address(this).balance}("");
require(sent, "err-native-liquidate");
}
}
if protocol address (the treasury) is set wrong say to an address that reverts in the receive() function then the vault can never be liquidated by the vault manager, there should be checks for this at the time of deployment.
Recommendations
protocol fee taking should be in a seperate function which can be triggered by the smart vault manager instead of being clubbed with liquidation logic.
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
informational/invalid
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.