The Standard

Summary

The code currently relies on standard ERC20 transfer() and transferFrom() functions, which may pose issues with certain tokens like Tether (USDT) that deviate from the ERC20 standard. To enhance compatibility and prevent reverted calls, it is recommended to replace these functions with OpenZeppelin's SafeERC20's safeTransfer() and safeTransferFrom().

Vulnerability Details

LiquidationPool.sol

LiquidationPoolManager.sol

Impact

The current implementation may encounter issues, especially with tokens like Tether (USDT), where the lack of boolean return values in the transfer() and transferFrom() functions can lead to reverted calls.

Tools Used

Manual review

Recommendations

Replace the usage of standard ERC20 transfer() and transferFrom() functions with OpenZeppelin's SafeERC20's safeTransfer() and safeTransferFrom() to ensure compatibility with tokens that do not fully adhere to the ERC20 standard.