Submission Details
Severity:
Dividing before multiplication leads to rounding error
Summary
Solidity's integer division truncates. Thus, performing division before multiplication can lead to precision loss.
Vulnerability Details
distributeAssets(ILiquidationPoolManager.Asset[],uint256,uint256) performs a multiplication on the result of a division:
costInEuros = _portion * 10 ** (18 - asset.token.dec) * uint256(assetPriceUsd) / uint256(priceEurUsd) * _hundredPC / _collateralRate
Impact
Tools Used
slither, manual review
Recommendations
Consider ordering multiplication before division.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933
USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.