Submission Details
Severity:
SmartVaultV3::swap() deadline parameter is too low and could cause a swap to fail
Summary and Vulnerability Details
The deadline parameter in ExactInputSingleParams specifies the unix time after which a swap will fail. The currently provided value is block.timestamp, which could cause swaps to fail in production.
Impact
Swaps could fail on mainnet.
Tools Used
Manual Review
Recommendations
Ideally, this should be configurable by the user and an additional argument should be added to the swap() function. Otherwise, the following code can be used:
deadline: block.timestamp + 60
Updates
Lead Judging Commences
hrishibhat over 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
deadline-check-low
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
60933 USDC / LOC
17,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.