The Standard

DeFiHardhat

20,000 USDC

View results

Previous Next

Submission Details

Severity: low

Invalid

Code does not follow the best practice of check-effects-interaction

0x6980

Summary

Vulnerability Details

Code should follow the best-practice of check-effects-interaction, where state variables are updated before any external calls are made. Doing so prevents a large class of reentrancy bugs.

Impact

Instances (13):

File: contracts/LiquidationPool.sol

/// @audit distributeFees called prior to this assignment

155: positions[msg.sender].TST -= _tstVal;

/// @audit distributeFees called prior to this assignment

159: positions[msg.sender].EUROs -= _eurosVal;

/// @audit getAcceptedTokens() called prior to this

170: delete rewards[abi.encodePacked(msg.sender, _token.symbol)];

/// @audit safeTransferFrom called prior to this assignment

188: positions[_holder].EUROs += _amount * positions[_holder].TST / tstTotal;

/// @audit safeTransferFrom called prior to this assignment

191: pendingStakes[i].EUROs += _amount * pendingStakes[i].TST / tstTotal;

/// @audit safeTransferFrom called prior to this assignment

237: positions[holders[j]] = _position;

155, 159, 170, 188, 191, 237

File: contracts/LiquidationPoolManager.sol