Submission Details
Severity:
Unable To Mint More Than One in Huff Code
Summary
The huff version is unable to mint more than one "horse" due to a bad implementation.
Vulnerability Details
This is easy to prove with a simple test:
function test_huffSingleMint() external {
vm.startPrank(peter);
horseStore.mintHorse();
horseStore.mintHorse();
vm.stopPrank();
assertEq(horseStore.balanceOf(peter), 2);
}
➜ 2024-01-horse-store git:(main) ✗ forge test --mt test_huffSingleMint
[⠢] Compiling...
[⠔] Compiling 1 files with 0.8.20Compiler run successful!
[⠒] Compiling 1 files with 0.8.20
[⠑] Solc 0.8.20 finished in 1.39s
Running 1 test for test/HorseStoreHuff.t.sol:HorseStoreHuff
[FAIL. Reason: revert: ALREADY_MINTED] test_huffSingleMint() (gas: 59935)
Test result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 526.54ms
Ran 1 test suites: 0 tests passed, 1 failed, 0 skipped (1 total tests)
Failing tests:
Encountered 1 failing test in test/HorseStoreHuff.t.sol:HorseStoreHuff
[FAIL. Reason: revert: ALREADY_MINTED] test_huffSingleMint() (gas: 59935)
Encountered a total of 1 failing tests, 0 tests succeeded
➜ 2024-01-horse-store git:(main) ✗
Impact
The HUFF version of the protocol is broken as it is unable to mint more than one token.
Tools Used
Foundry
Recommendations
The protocol need to add a nextId variable that increase with each mint, so the protocol and mint function has a new Id each operation.
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Failure to increment total supply on mint
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.