Submission Details
Severity:
Huff version doesn´t allow not EOA addresses to mint
Summary
Contrary to Solidity's version, Huff's version does not correctly implement safeMint() so it does not allow NFTs to be minted when the msg.sender is a smart contract.
Vulnerability Details
Let's create a smart contract to call the
mintHorse()function.
// SPDX-License-Identifier: UNLICENSED
import "./IHorseStore.sol";
import "@openzeppelin/contracts/token/ERC721/ERC721.sol";
import "@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol";
contract MinterContract {
IHorseStore public horseStore;
constructor(address _horseStore) {
horseStore = IHorseStore(_horseStore);
}
function callingFunctions() external {
horseStore.mintHorse();
}
function onERC721Received(address _msgSender, address _from, uint256 _tokenId, bytes calldata _data)
external
returns (bytes4 retval)
{
return IERC721Receiver.onERC721Received.selector;
}
}
We create the same test for both version:
For Solidity version
function test_contractFeatures() external {
minterContract.callingFunctions();
assertEq(horseStore.totalSupply(), 1);
}
If we run the test:
➜ 2024-01-horse-store git:(main) ✗ forge test --mt test_contractFeatures
[⠒] Compiling...No files changed, compilation skipped
[⠢] Compiling...
Running 1 test for test/HorseStoreSolidity.t.sol:HorseStoreSolidity
[PASS] test_contractFeatures() (gas: 94099)
Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 973.83µs
Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests)
For huff version (
totalSupply()doesn´t works)
function test_huffContractFeatures() external {
minterContract.callingFunctions();
}
If we run the test:
➜ 2024-01-horse-store git:(main) ✗ forge test --mt test_huffContractFeatures
[⠒] Compiling...No files changed, compilation skipped
[⠢] Compiling...
Running 1 test for test/HorseStoreHuff.t.sol:HorseStoreHuff
[FAIL. Reason: EvmError: Revert] test_huffContractFeatures() (gas: 2567)
Test result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 660.72ms
Ran 1 test suites: 0 tests passed, 1 failed, 0 skipped (1 total tests)
Failing tests:
Encountered 1 failing test in test/HorseStoreHuff.t.sol:HorseStoreHuff
[FAIL. Reason: EvmError: Revert] test_huffContractFeatures() (gas: 2567)
Encountered a total of 1 failing tests, 0 tests succeeded
➜ 2024-01-horse-store git:(main) ✗
Impact
This is a HIGH vulnerability because if the Solidity version allows mining to non-EOA addresses, the HUFF version must act in the same way.
Tools Used
Foundry
Recommendations
safeMint should be implemented correctly.
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Components of ERC721 not properly (or at all) implemented in HUFF
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.