Submission Details
Severity:
Horses can be fed without existing
Description
There is no check if a horse exists before feeding it.
function feedHorse(uint256 horseId) external {
@>
horseIdToFedTimeStamp[horseId] = block.timestamp;
}
The same case exists in HorseStore.huff.
Impact
A user feeding a non-existing horse won't trigger a revert and can lead to confusion.
Unexpected logic for the protocol.
Proof of Concept
Foundry PoC
function testFeedNonCreatedHorseIsNotHappy() public {
skip(2 days);
uint nonCreatedHorseID = 100;
// will work even if nobody minted this horse!
horseStore.feedHorse(nonCreatedHorseID);
// will fail because, in addition, the non-existing horse is considered happy
assertEq(horseStore.isHappyHorse(nonCreatedHorseID), false);
}
Recommended Mitigation
Add a check in both contracts to ensure that a horse exists before feeding it. A simple check is to call ownerOf with the tokenId; this function will revert if the token is not minted.
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Nonexistent horses can be fed
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.