Submission Details
Severity:
Horses can be not happy without existing
Description
If both Huff and Solidity files, there is no check if a horse exists before reading the mapping in isHappyHorse. As a result, all non-existing horses are considered not happy instead of reverting with an error.
Impact
Confusion with returned data.
Unexpected logic for the protocol.
Proof of Concept
Foundry PoC
function testFeedNonCreatedHorseIsNotHappy() public {
skip(2 days);
uint nonCreatedHorseID = 100;
// will succeed even if the horse doesn't exist!
assertEq(horseStore.isHappyHorse(nonCreatedHorseID), false);
}
Recommended Mitigation
Add a check in both contracts to ensure that a horse exists before returning its happiness status. A simple check is to call ownerOf with the tokenId; this function will revert if the token is not minted.
Rewards breakdown
nSLOC
460This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.