Submission Details
Severity:
Unnecesary OR, renders the overflow check useless
Summary
OR assembly operation in if statement can affect its intended functionality and not revert when it shoud.
Vulnerability Details
The or function in yul affects the value of the division div(not(0), y), x), this gives in incorrect results for the gt function thus not reverting when it should
Impact
High - Incorrect functionality
Tools Used
Manual testing.
Chisel to verify step by step.
Recommendations
Remove or function, if statement should just look like the one on mulWad.
Updates
Lead Judging Commences
inallhonesty
almost 2 years ago
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
`mulWadUp` has a bad overflow check
Rewards breakdown
nSLOC
46This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.