Submission Details
Severity:
If statement incorrectly adds 1 to x
Summary
Line 56 if iszero(sub(div(add(z, x), y), 1)) { x := add(x, 1) } adds 1 to x if x and y are the same WAD number.
Vulnerability Details
When executing mulWadUp with value 3e18 for x and y it adds 3 to the number giving an incorrect result:
function testMulWadUpWrongResult() public {
console2.log("Test start");
uint256 x = 3e18;
uint256 y = 3e18;
uint256 z = MathMasters.mulWadUp(x, y);
console2.logUint(z); // 9000000000000000003 -> should be 9000000000000000000
}
Impact
High - incorrect functionality
Tools Used
forge test --match-test testMulWadUpWrongResult -vv
Recommendations
Remove line 56
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
`mulWadUp` has an unnecessary line that makes the result wrong for some inputs
Rewards breakdown
nSLOC
46This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.