Submission Details
Severity:
Contract Name Reused
Summary
If a codebase has two contracts the similar names, the compilation artifacts will not contain one of the contracts with the duplicate name.
Vulnerability Details
File: contracts/beanstalk/sun/SeasonFacet/Oracle.sol
/// @audit ******************* Issue Detail *******************
Oracle is re-used:
- Oracle (contracts/beanstalk/sun/SeasonFacet/Oracle.sol#17-27)
- Oracle (node_modules/@uniswap/v3-core/contracts/libraries/Oracle.sol#11-325)
/// @audit ****************** Affected Code *******************
17: contract Oracle is ReentrancyGuard {
18:
19: using SignedSafeMath for int256;
20:
21: //////////////////// ORACLE INTERNAL ////////////////////
22:
23: function stepOracle() internal returns (int256 deltaB) {
24: deltaB = LibWellMinting.capture(C.BEAN_ETH_WELL);
25: s.season.timestamp = block.timestamp;
26: }
27: }
Impact
One of the contract named Oracle will not be included due to duplicate name which will produce wrong results at runtime.
Tools Used
Manual Aided Review
Recommendations
Rename one of the contract.
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Lack of quality
Assigned finding tags:
Informational/Invalid
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.