Submission Details
Severity:
Unchecked transfer
Summary
The return value of an external transfer/transferFrom call is not checked
Vulnerability Details
File: contracts/libraries/Convert/LibWellConvert.sol
/// @audit ******************* Issue Detail *******************
LibWellConvert._wellAddLiquidityTowardsPeg(uint256,uint256,address) (contracts/libraries/Convert/LibWellConvert.sol#194-207) ignores return value by:
- C.bean().transfer(well,beansConverted) (contracts/libraries/Convert/LibWellConvert.sol#202)
/// @audit ************** Possible Issue Line(s) **************
L#202,
/// @audit ****************** Affected Code *******************
194: function _wellAddLiquidityTowardsPeg(
195: uint256 beans,
196: uint256 minLP,
197: address well
198: ) internal returns (uint256 lp, uint256 beansConverted) {
199: (uint256 maxBeans, ) = _beansToPeg(well);
200: require(maxBeans > 0, "Convert: P must be >= 1.");
201: beansConverted = beans > maxBeans ? maxBeans : beans;
202: C.bean().transfer(well, beansConverted);
203: lp = IWell(well).sync(
204: address(this),
205: minLP
206: );
207: }
Impact
Protocol always assume that transfer will be successful and does not handle the case for unsuccessful trasnfer.
Tools Used
Manual Aided Review
Recommendations
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Updates
Lead Judging Commences
giovannidisiena over 1 year ago
Submission Judgement Published Reason: Incorrect statement
Assigned finding tags:
Bean transfer return
Prize pool breakdown
Total prize
100,000 USDC
nSLOC
5,77617 USDC / LOC
95,000 USDC
5,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.